[webkit-reviews] review granted: [Bug 171095] [MediaCapture][iOS] AVAudioSession must be active and the correct category before IO AudioUnits start producing data. : [Attachment 307681] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 171095: [MediaCapture][iOS] AVAudioSession must be active and the correct
category before IO AudioUnits start producing data.
https://bugs.webkit.org/show_bug.cgi?id=171095

Attachment 307681: Patch

https://bugs.webkit.org/attachment.cgi?id=307681&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 307681
  --> https://bugs.webkit.org/attachment.cgi?id=307681
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307681&action=review

> Source/WebCore/Modules/mediastream/MediaStream.cpp:448
> +    if (m_private->hasAudio() && m_isProducingData &&
m_private->hasCaptureAudioSource())

It would seem logic to have m_private->hasAudio() if
m_private->hasCaptureAudioSource().
Is there a redundant check?