[webkit-reviews] review requested: [Bug 171090] WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:... : [Attachment 307664] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 171090: WebContent process becomes unresponsive after returning nil from
async version of -webView:createWebViewWithConfiguration:...
https://bugs.webkit.org/show_bug.cgi?id=171090

Attachment 307664: Patch

https://bugs.webkit.org/attachment.cgi?id=307664&action=review




--- Comment #4 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 307664
  --> https://bugs.webkit.org/attachment.cgi?id=307664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307664&action=review

>> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:198
>>		    [NSException raise:NSInternalInconsistencyException
format:@"Returned WKWebView was not created with the given configuration."];
> 
> If this exception is caught, does it leave the WebProcess in an unresponsive
state as well?

No.

Though it's a good point here...  should we allow a bogusly created WebView
through just because the app caught the exception?

Same possibility has always existed for the synchronous form of this API, so
it's not a new issue.