[webkit-reviews] review granted: [Bug 171090] WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:... : [Attachment 307664] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 171090: WebContent process becomes unresponsive after returning nil from
async version of -webView:createWebViewWithConfiguration:...
https://bugs.webkit.org/show_bug.cgi?id=171090

Attachment 307664: Patch

https://bugs.webkit.org/attachment.cgi?id=307664&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 307664
  --> https://bugs.webkit.org/attachment.cgi?id=307664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307664&action=review

> Source/WebKit2/UIProcess/Cocoa/UIDelegate.mm:-198
> -	       if (!webView)
> -		   return;

Can you call completionHandler with nullptr here and then not bother with the
null checks below?

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:180
>  // https://bugs.webkit.org/show_bug.cgi?id=171083 - Try to figure out why
this fails for some configs but not others, and resolve.
>  //TEST(WebKit2, OpenAndCloseWindowAsyncCallbackException)
>  //{
> -//	 openedWebView = nullptr;
> -//	 isDone = false;
> +//	 resetToConsistentState();
>  //
>  //	 RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 800, 600)]);
>  //

Commented out code!