[webkit-reviews] review denied: [Bug 171085] commit-log-editor should respect the git editor if one is set : [Attachment 307656] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Conrad Shultz
<conrad_shultz at apple.com>'s request for review:
Bug 171085: commit-log-editor should respect the git editor if one is set
https://bugs.webkit.org/show_bug.cgi?id=171085

Attachment 307656: Patch

https://bugs.webkit.org/attachment.cgi?id=307656&action=review




--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 307656
  --> https://bugs.webkit.org/attachment.cgi?id=307656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307656&action=review

> Tools/Scripts/commit-log-editor:97
> +if (isGit()) {
> +    $editor = $ENV{GIT_EDITOR};
> +    $editor = `git config --global --get core.editor` if !$editor;
> +}

Take GIT_EDITOR := vi and "git config core.editor" :=
Tools/Scripts/commit-log-editor. Make a change to some file and run "git commit
-a". Then Git will invoke vi directly instead of commit-log-editor by
definition of GIT_EDITOR in <https://git-scm.com/docs/git-var#_variables>. That
is, we never run this code.

We should take a similar approach as for SVN_LOG_EDITOR and CVS_LOG_EDITOR and
query for an environment variable that does not coincide with an environment
variable used by Git, say GIT_LOG_EDITOR.