[webkit-reviews] review granted: [Bug 171079] virtualThunkFor() needs to materialize its of tagMaskRegister for tail calls. : [Attachment 307654] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 171079: virtualThunkFor() needs to materialize its of tagMaskRegister for
tail calls.
https://bugs.webkit.org/show_bug.cgi?id=171079

Attachment 307654: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=307654&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307654
  --> https://bugs.webkit.org/attachment.cgi?id=307654
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=307654&action=review

r=me

> Source/JavaScriptCore/jit/AssemblyHelpers.h:429
> +    void emitMaterializeTagMaskInRegister(GPRReg reg)
> +    {
> +	   move(MacroAssembler::TrustedImm64(TagTypeNumber), reg);
> +	   orPtr(MacroAssembler::TrustedImm32(TagBitTypeOther), reg, reg);
> +    }

Please verify this is less code on X86_64 and ARM64, otherwise, please
specialize to those platforms what you do such that we emit less code.