[webkit-reviews] review requested: [Bug 163412] REGRESSION: MessageEvent.source for bound postMessage() is wrong for same-origin iframe : [Attachment 307623] Patch and layout tests

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 163412: REGRESSION: MessageEvent.source for bound postMessage() is wrong
for same-origin iframe
https://bugs.webkit.org/show_bug.cgi?id=163412

Attachment 307623: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=307623&action=review




--- Comment #20 from Daniel Bates <dbates at webkit.org> ---
Created attachment 307623

  --> https://bugs.webkit.org/attachment.cgi?id=307623&action=review

Patch and layout tests

Modified WebCore::callerDOMWindow() to return the first DOM window if did not
find non-native code in the stack trace and the currently running code was not
scheduled (say, via setTimeout()). This fixes the assertion failure and makes
another subtest pass in
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/scripting/events/co
mpile-event-handler-settings-objects.html. This also preserves our current
behavior of returng the first DOM window as the calling DOM window should
WebCore::callerDOMWindow() be invoked when running Wasm code (see bug #165721).