[webkit-reviews] review granted: [Bug 170980] [WinCairo] Fix build break after updating ANGLE : [Attachment 307559] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 20 12:59:26 PDT 2017
Brent Fulgham <bfulgham at webkit.org> has granted review:
Bug 170980: [WinCairo] Fix build break after updating ANGLE
https://bugs.webkit.org/show_bug.cgi?id=170980
Attachment 307559: Patch
https://bugs.webkit.org/attachment.cgi?id=307559&action=review
--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 307559
--> https://bugs.webkit.org/attachment.cgi?id=307559
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=307559&action=review
I think this looks good, but I'm worried this might break GTK. Can you confirm?
Otherwise r=me.
> Source/ThirdParty/ANGLE/CMakeLists.txt:-45
> - src/common/system_utils_linux.cpp
Where did this go? Shouldn't it move to PlatformGTK or somewhere, like you did
for Mac and Windows?
> Source/WebCore/platform/graphics/PlatformDisplay.cpp:-192
> -#endif
Oh, nice!
More information about the webkit-reviews
mailing list