[webkit-reviews] review requested: [Bug 167343] webkit-gtk-2.15.3 fails to build on macOS due to missing declaration of U8_MAX_LENGTH : [Attachment 307612] Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h with corrections as requested.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 20 12:24:54 PDT 2017


John Ralls <jralls at ceridwen.us> has asked  for review:
Bug 167343: webkit-gtk-2.15.3 fails to build on macOS due to missing
declaration of U8_MAX_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=167343

Attachment 307612: Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h with
corrections as requested.

https://bugs.webkit.org/attachment.cgi?id=307612&action=review




--- Comment #10 from John Ralls <jralls at ceridwen.us> ---
Created attachment 307612

  --> https://bugs.webkit.org/attachment.cgi?id=307612&action=review

Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h with corrections as
requested.

Sorry about all of the noise in the previous iteration. It didn't occur to me
that there'd be hand-built Makefiles when there's a CMake implementation too.

I didn't get any messages from EWS. Should I have?

I did a test-build in Xcode which completed successfully, but that would be of
Safari's backend rather than WebKitGtk.


More information about the webkit-reviews mailing list