[webkit-reviews] review granted: [Bug 170956] Reduce copies and allocations in SharedBuffer::append : [Attachment 307596] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 20 10:21:59 PDT 2017


Andreas Kling <akling at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170956: Reduce copies and allocations in SharedBuffer::append
https://bugs.webkit.org/show_bug.cgi?id=170956

Attachment 307596: Patch

https://bugs.webkit.org/attachment.cgi?id=307596&action=review




--- Comment #14 from Andreas Kling <akling at apple.com> ---
Comment on attachment 307596
  --> https://bugs.webkit.org/attachment.cgi?id=307596
Patch

r=me

We currently need the data() buffer flattening support for image decoders on
mac and iOS, so we won't be able to get rid of that unless we get some new
framework support.

Could we also do something with the Content-Length HTTP header if present?
Pre-allocating the final buffer size right away might reduce allocations even
further.


More information about the webkit-reviews mailing list