[webkit-reviews] review granted: [Bug 169458] [INTL] Implement Intl.DateTimeFormat.prototype.formatToParts : [Attachment 307593] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 169458: [INTL] Implement Intl.DateTimeFormat.prototype.formatToParts
https://bugs.webkit.org/show_bug.cgi?id=169458

Attachment 307593: Patch

https://bugs.webkit.org/attachment.cgi?id=307593&action=review




--- Comment #42 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 307593
  --> https://bugs.webkit.org/attachment.cgi?id=307593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307593&action=review

Thanks! I noticed two small things, sorry for missing them earlier. I'll CQ
after you fix.

> Source/JavaScriptCore/runtime/IntlDateTimeFormat.h:119
> +    WriteBarrier<JSBoundFunction> m_boundFormatToParts;

I just noticed that this field is unused?

> Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp:87
> +#endif

Can you add:
#else
  UNUSED_PARAM(globalObject);