[webkit-reviews] review granted: [Bug 171028] -Wformat warning on HistoryController.cpp:295:5 : [Attachment 307539] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 19 21:33:50 PDT 2017

Daniel Bates <dbates at webkit.org> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 171028: -Wformat warning on HistoryController.cpp:295:5

Attachment 307539: Patch


--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 307539
  --> https://bugs.webkit.org/attachment.cgi?id=307539

View in context: https://bugs.webkit.org/attachment.cgi?id=307539&action=review

I am assuming that -Wall does not include -Wformat and that we do not enable
-Wformat on the Mac, iOS, or Windows bots as I have not seen this failure. We
should look to enable -Wformat on these bots.

> Source/WebCore/ChangeLog:7
> +

Please explain the change.

More information about the webkit-reviews mailing list