[webkit-reviews] review granted: [Bug 170740] WebAssembly: import GCC torture tests : [Attachment 307432] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 19 09:41:53 PDT 2017

Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 170740: WebAssembly: import GCC torture tests

Attachment 307432: patch


--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307432
  --> https://bugs.webkit.org/attachment.cgi?id=307432

View in context: https://bugs.webkit.org/attachment.cgi?id=307432&action=review

Nice. r=me

> Tools/ChangeLog:3
> +	   WebAssembly: import GCC torture tests

Nit: I'd make the bug title reflect what the patch actually does.

> Tools/Scripts/update-wasm-gcc-torture.py:96
> +def waterfall_known_failures(args):

What determines if something is a failure? If it's just that v8 fails that
test, perhaps that's not the metric we want to use.

More information about the webkit-reviews mailing list