[webkit-reviews] review granted: [Bug 169458] [INTL] Implement Intl.DateTimeFormat.prototype.formatToParts : [Attachment 307076] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 169458: [INTL] Implement Intl.DateTimeFormat.prototype.formatToParts
https://bugs.webkit.org/show_bug.cgi?id=169458

Attachment 307076: Patch

https://bugs.webkit.org/attachment.cgi?id=307076&action=review




--- Comment #23 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 307076
  --> https://bugs.webkit.org/attachment.cgi?id=307076
Patch

Sorry for the delay, this scrolled off my inbox :(

(In reply to Andy VanWagoner from comment #22)
> (In reply to JF Bastien from comment #19)
> > So it looks like we have 4 copies of the ICU headers, and from the readme
in
> > them they're only there to build on some really old MacOS which didn't
> > provide the ICU headers.
> > 
> > Would it be possible to just... get rid of those 4 copies?
> > 
> > Barring that, we should probably update all 4 to the same version.
> 
> I think it would be great to remove the ICU headers. As best I can tell from
> the project files we probably don't build for earlier than 10.10 at this
> point.
> 
> Can we look at making a sweeping change like that (removing or updating all
> ICU headers) in a separate patch?

Yes, this sounds good. Can you file a bug for it?