[webkit-reviews] review denied: [Bug 167343] webkit-gtk-2.15.3 fails to build on macOS due to missing declaration of U8_MAX_LENGTH : [Attachment 307444] Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h, this time without the transposition.

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied John Ralls
<jralls at ceridwen.us>'s request for review:
Bug 167343: webkit-gtk-2.15.3 fails to build on macOS due to missing
declaration of U8_MAX_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=167343

Attachment 307444: Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h, this
time without the transposition.

https://bugs.webkit.org/attachment.cgi?id=307444&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 307444
  --> https://bugs.webkit.org/attachment.cgi?id=307444
Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h, this time without the
transposition.

Thanks for your patch. This does need some work. First off, and most
importantly, the patch should not touch the hand-written Makefiles, since those
are part of the XCode build. It should certainly not replace them with
CMake-generated files, which are not source and should not be under version
control. I haven't reviewed the rest of the changes since the vast majority of
the diff is changes to the Makefiles, so I'll look over the rest of the patch
once those changes are removed. Note: you should use a separate build directory
in order to ensure that generated files like these Makefiles aren't created in
the source directory; I'm kind of surprised that an in-tree build worked at
all, since we've never tested or supported that.

You can ignore all the complaints from style checker, since this is a straight
rename, but you can't ignore the red Early Warning System (EWS) bots. This
broke the iOS Simulator, JSC, and Mac EWS bots. The problem is that the XCode
build needs to be updated to account for the rename in addition to the CMake
build; those bots don't use CMake at all. Normally I would ask someone from
Apple to do that, but since you use macOS I guess you can probably handle it
yourself? If not, perhaps Sam would be willing to help with that.

Please use Tools/Scripts/prepare-ChangeLog to prepare your changelog entries.
In particular, note that you won't actually modify the toplevel ChangeLog file,
but the ChangeLog files in the JavaScriptCore, WTF, WebCore, and WebKit2
directories. It will say "Reviewed by NOBODY (OOPS!)" and it's best to leave
that in the patch you upload, since our tools will handle replacing it
automatically.