[webkit-reviews] review requested: [Bug 167343] webkit-gtk-2.15.3 fails to build on macOS due to missing declaration of U8_MAX_LENGTH : [Attachment 307443] Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h

[bugzilla-daemon at webkit.org]

John Ralls <jralls at ceridwen.us> has asked  for review:
Bug 167343: webkit-gtk-2.15.3 fails to build on macOS due to missing
declaration of U8_MAX_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=167343

Attachment 307443: Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h

https://bugs.webkit.org/attachment.cgi?id=307443&action=review




--- Comment #1 from John Ralls <jralls at ceridwen.us> ---
Created attachment 307443

  --> https://bugs.webkit.org/attachment.cgi?id=307443&action=review

Rename Source/WTF/wtf/unicode/UTF8.h to .../wtf_utf8.h

This problem has a long history: Bugs 63948, 65811, 70913, 72152, and 88307.
The "fix" implemented in a patch at bug 70913 worked until CMake came along,
but now CMake's dependency-discovery mechanism appends Source/WTF/wtf to the
include list and ICU's #include "unicode/utf8.h" (in unicode/utf.h) finds it
again.

This patch renames the offending UTF8.h and UTF8.cpp to wtf_utf8.h and
wtf_utf8.cpp, which is what should have been done in the first place.