[webkit-reviews] review granted: [Bug 170966] RTCOfferOptions iceRestart should be supported : [Attachment 307414] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170966: RTCOfferOptions iceRestart should be supported
https://bugs.webkit.org/show_bug.cgi?id=170966

Attachment 307414: Patch

https://bugs.webkit.org/attachment.cgi?id=307414&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307414
  --> https://bugs.webkit.org/attachment.cgi?id=307414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307414&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:67
> +    void doCreateOffer(const RTCOfferOptions&);

Would it make sense to pass a RTCOfferOptions&& to mirror the parameter type in
LibWebRTCPeerConnectionBackend::doCreateOffer?