[webkit-reviews] review denied: [Bug 170954] libwebrtc VideoToolboxVideoEncoderFactory should call CreateSupportedVideoEncoder : [Attachment 307405] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170954: libwebrtc VideoToolboxVideoEncoderFactory should call
CreateSupportedVideoEncoder
https://bugs.webkit.org/show_bug.cgi?id=170954

Attachment 307405: Patch

https://bugs.webkit.org/attachment.cgi?id=307405&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307405
  --> https://bugs.webkit.org/attachment.cgi?id=307405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307405&action=review

I like this.  Let's split it up and do it cleanly.

> Source/WebCore/ChangeLog:10
> +	   * platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp:

This change is not in this patch.

> Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:75
> +DEAD_CODE_STRIPPING_normal = YES;

This cuts almost 1MB of code from release libwebrtc.dylib!

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/videotoolb
oxvideocodecfactory.cc:40
> -    return new H264VideoToolboxEncoder(codec);
> +    return CreateSupportedVideoEncoder(codec);

This change is unrelated to the rest of the changes in this patch.  The other
changes should be in a separate patch titled something like "Strip dead code
from release libwebrtc.dylib"