[webkit-reviews] review granted: [Bug 170961] r211670 broke double to int conversion. : [Attachment 307406] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 18 13:39:21 PDT 2017

Yusuke Suzuki <utatane.tea at gmail.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 170961: r211670 broke double to int conversion.

Attachment 307406: proposed patch.


--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 307406
  --> https://bugs.webkit.org/attachment.cgi?id=307406
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=307406&action=review

r=me if it does not regress DoubleAsInt32.

> Source/JavaScriptCore/runtime/MathCommon.h:93
> +    if (static_cast<uint32_t>(exp) > 83u)


More information about the webkit-reviews mailing list