[webkit-reviews] review granted: [Bug 170926] [WebIDL] Make annotated types first class allowing them to be used in sequences and unions : [Attachment 307341] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 170926: [WebIDL] Make annotated types first class allowing them to be used
in sequences and unions
https://bugs.webkit.org/show_bug.cgi?id=170926

Attachment 307341: Patch

https://bugs.webkit.org/attachment.cgi?id=307341&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 307341
  --> https://bugs.webkit.org/attachment.cgi?id=307341
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307341&action=review

r=me, nice.

> Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp:252
>      if (value.isInt32())

We may even want to LIKELY() this branch.

> Source/WebCore/bindings/js/JSDOMConvertNumbers.cpp:265
> +    if (value.isUInt32())

We may even want to LIKELY() this branch.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5379
> +sub GetAnnotatedIDLType

Having 2 subroutines that need to be kept in sync seems a bit unfortunate.
Could we maybe drop the IsAnnotatedType() one and rely on GetAnnotatedIDLType()
returning something or not?