[webkit-reviews] review granted: [Bug 170943] [DFG] Convert ValueAdd(Int32, String) => MakeRope(ToString(Int32), String) : [Attachment 307393] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 170943: [DFG] Convert ValueAdd(Int32, String) => MakeRope(ToString(Int32),
String)
https://bugs.webkit.org/show_bug.cgi?id=170943

Attachment 307393: Patch

https://bugs.webkit.org/attachment.cgi?id=307393&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 307393
  --> https://bugs.webkit.org/attachment.cgi?id=307393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307393&action=review

r=me

> Source/JavaScriptCore/ChangeLog:35
> +	       template_string_tag.es5	     200.1027+-20.6871	  ^    
25.7925+-11.4052       ^ definitely 7.7582x faster

LOL bad benchmark :(