[webkit-reviews] review granted: [Bug 170941] Update ANGLE : [Attachment 307372] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 170941: Update ANGLE
https://bugs.webkit.org/show_bug.cgi?id=170941

Attachment 307372: Patch

https://bugs.webkit.org/attachment.cgi?id=307372&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307372
  --> https://bugs.webkit.org/attachment.cgi?id=307372
Patch

r=me
WebCore changes are just changing ShSomething to sh::Something. 
Straightforward.
The EGL and GLESv2 soft linking was only helping people distributing WinCairo
and not wanting to distribute libGLESv2.dll and libEGL.dll, which I think is
nobody.  If somebody wants to do that, they can bring the soft linking back.
It looks like ANGLE now includes an Xcode build in the file you included as
Source/ThirdParty/ANGLE/src/angle.xcodeproj/project.pbxproj and maybe we could
adopt that sometime.  Let's assume no until we find a benefit of doing so.
The Apple-added comments in ExpressionParser.cpp, glslang_tab.cpp, and
glslang_tab.h remain.