[webkit-reviews] review granted: [Bug 170764] [css-grid] Add support for percentage gaps : [Attachment 306897] Mini change on ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 18 07:43:00 PDT 2017

Sergio Villar Senin <svillar at igalia.com> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 170764: [css-grid] Add support for percentage gaps

Attachment 306897: Mini change on ChangeLog


--- Comment #7 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 306897
  --> https://bugs.webkit.org/attachment.cgi?id=306897
Mini change on ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=306897&action=review

> LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html:15
> +.rows50-50 { grid-template-rows: 50px 50px; }

We haven't used this kind of notation %d-%d for class names in the past. We
normally do things like two100Column or things like that.

> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:33
> +.gridInvalidColumnGap { grid-column-gap: -webkit-max-content; }

Seems unrelated?

> LayoutTests/fast/css-grid-layout/grid-gutters-get-set.html:44
> +.gridInvalidImplicitGridGap { grid-gap: -webkit-fit-content; }


More information about the webkit-reviews mailing list