[webkit-reviews] review granted: [Bug 163208] [ES6]. Implement Annex B.3.3 function hoisting rules for eval : [Attachment 307127] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 163208: [ES6]. Implement Annex B.3.3 function hoisting rules for eval
https://bugs.webkit.org/show_bug.cgi?id=163208

Attachment 307127: Patch

https://bugs.webkit.org/attachment.cgi?id=307127&action=review




--- Comment #74 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307127
  --> https://bugs.webkit.org/attachment.cgi?id=307127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307127&action=review

Nice! r=me

> Source/JavaScriptCore/parser/Parser.cpp:1784
> +    if (!currentScope()->isFunction() &&
!closestParentOrdinaryFunctionNonLexicalScope()->isEvalContext()) {

Please update the comment below, since you're now adding this for eval.