[webkit-reviews] review granted: [Bug 170916] Web Inspector: Enabled state of "All Requests" XHR breakpoint not restored correctly : [Attachment 307299] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted  review:
Bug 170916: Web Inspector: Enabled state of "All Requests" XHR breakpoint not
restored correctly
https://bugs.webkit.org/show_bug.cgi?id=170916

Attachment 307299: Patch

https://bugs.webkit.org/attachment.cgi?id=307299&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307299
  --> https://bugs.webkit.org/attachment.cgi?id=307299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307299&action=review

>> Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js:71
>> +		    this._updateXHRBreakpoint(this._allRequestsBreakpoint);
> 
> r- I do not think this makes sense in DOMDebuggerManager.
> 
> Workers can have "XHR"Breakpoints but they cannot have "DOM"Breakpoints. So
I'd expect this in a location that would be compatible with workers.

Ahh, okay "DOMDebugger" is what holds all of the Web specific breakpoints (DOM,
XHR, eventually Event, Timeouts, etc). I was mistaken.

r=me