[webkit-reviews] review denied: [Bug 170827] Enough with these favicon.ico errors : [Attachment 307086] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170827: Enough with these favicon.ico errors
https://bugs.webkit.org/show_bug.cgi?id=170827

Attachment 307086: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307086&action=review




--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307086
  --> https://bugs.webkit.org/attachment.cgi?id=307086
[PATCH] Proposed Fix

This patch feels bad.  We're passing a loader around that is mostly nullptr
except one place.  The layering feels wrong but I'm not sure how to describe
what would be better.  This is a very specific case we want to ignore, but we
seem to be ignoring errors from ALL icon loads.  Also, there are no tests.