[webkit-reviews] review granted: [Bug 170913] Plumb all four obscured insets to WebCore, instead of just top/left : [Attachment 307293] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 170913: Plumb all four obscured insets to WebCore, instead of just top/left
https://bugs.webkit.org/show_bug.cgi?id=170913

Attachment 307293: Patch

https://bugs.webkit.org/attachment.cgi?id=307293&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 307293
  --> https://bugs.webkit.org/attachment.cgi?id=307293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307293&action=review

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=170913

Maybe add a "(Work towards )<rdar://problem/________>" here?

> Source/WebKit2/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=170913

Maybe add a "(Work towards )<rdar://problem/________>" here?

> Source/WebCore/platform/graphics/FloatRectInsets.cpp:33
> +TextStream& operator<<(TextStream& ts, const FloatRectInsets &insets)

"FloatRectInsets &" => "FloatRectInsets& "

> Source/WebCore/platform/graphics/FloatRectInsets.h:58
> +

Should this know how to convert to UIEdgeInsets via operator UIEdgeInsets()?
(like how FloatRect can convert to a CGRect).