[webkit-reviews] review granted: [Bug 170895] Web Inspector: Show pause reason for "All Requests" XHR breakpoint : [Attachment 307247] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 170895: Web Inspector: Show pause reason for "All Requests" XHR breakpoint
https://bugs.webkit.org/show_bug.cgi?id=170895

Attachment 307247: Patch

https://bugs.webkit.org/attachment.cgi?id=307247&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307247
  --> https://bugs.webkit.org/attachment.cgi?id=307247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307247&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1052
> +		   } else {

console.assert(pauseData.breakpointURL === "", "Should be the All Request
breakpoint which has an empty URL");

> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:1053
> +		       this._pauseReasonTextRow.text =
WebInspector.UIString("XHR sent: %s").format(pauseData.url);

I don't think "XHR sent" is correct. We haven't yet sent the XHR, we are about
to send it. As we saw last week, you should be able to change this XHR before
it is actually sent.

Some ideas:

    "Sending: %s"
    "Requesting: %s"
    "Sending Request: %s"
    "URL: %s"