[webkit-reviews] review granted: [Bug 170904] [WK2] Respect a new internal setting for defaulting to character selection granularity : [Attachment 307272] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Wenson Hsieh <wenson_hsieh at apple.com>'s request for
review:
Bug 170904: [WK2] Respect a new internal setting for defaulting to character
selection granularity
https://bugs.webkit.org/show_bug.cgi?id=170904

Attachment 307272: Patch

https://bugs.webkit.org/attachment.cgi?id=307272&action=review




--- Comment #4 from mitz at webkit.org ---
Comment on attachment 307272
  --> https://bugs.webkit.org/attachment.cgi?id=307272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307272&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:201
> +    BOOL defaultToSelectionGranularityCharacter = [[NSUserDefaults
standardUserDefaults]
boolForKey:@"WebKitDebugDefaultSelectionGranularityCharacter"] &&
WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstToUseSelectionGranularityChara
cterByDefault);
> +    _selectionGranularity = defaultToSelectionGranularityCharacter ?
WKSelectionGranularityCharacter : WKSelectionGranularityDynamic;

Perhaps for wider testing it would be good to make the user default affect all
apps regardless of when they were built?

Seems like this needs to be guarded with #if PLATFORM(IOS).