[webkit-reviews] review granted: [Bug 170697] CachedImage should cancel loading images for unsupported/unknown types : [Attachment 307254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 16 23:16:50 PDT 2017

youenn fablet <youennf at gmail.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 170697: CachedImage should cancel loading images for unsupported/unknown

Attachment 307254: Patch


--- Comment #20 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 307254
  --> https://bugs.webkit.org/attachment.cgi?id=307254

View in context: https://bugs.webkit.org/attachment.cgi?id=307254&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:407
>	   // Image decoding failed. Either we need more image data or the
image data is malformed.

This comment seems wrong to me from reading the code below.
If we need more image data, we should not call error(). We should just exit
early in order to wait for more data.
Can you check we are doing the right thing for this case and update the comment

> Source/WebCore/loader/cache/CachedImage.cpp:409
> +	   if (m_loader)

Can we have the case of a null m_loader in
Probably not, so we might be able to call m_loader->cancel() directly. Maybe
with an ASSERT(m_loader) before?

More information about the webkit-reviews mailing list