[webkit-reviews] review granted: [Bug 170858] consider switching all http://svn.webkit.org links to https://svn.webkit.org : [Attachment 307150] v2 patch, removing previous tab.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 170858: consider switching all http://svn.webkit.org links to
https://svn.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=170858

Attachment 307150: v2 patch, removing previous tab.

https://bugs.webkit.org/attachment.cgi?id=307150&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 307150
  --> https://bugs.webkit.org/attachment.cgi?id=307150
v2 patch, removing previous tab.

View in context: https://bugs.webkit.org/attachment.cgi?id=307150&action=review

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:55
> -    _revision_regexp = re.compile(r'^git-svn-id:
http://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+)
(?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE)
> +    _revision_regexp = re.compile(r'^git-svn-id:
https://svn.webkit.org/repository/webkit/trunk@(?P<svnid>\d+)
(?P<gitid>[0-9a-f\-]{36})$', re.MULTILINE)

Would it make sense to support both http and https here?