[webkit-reviews] review granted: [Bug 170860] [WinCairo] Consolidate CMake code related to CURL : [Attachment 307163] Patch with CMake changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 23:30:45 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Don Olmstead
<don.olmstead at am.sony.com>'s request for review:
Bug 170860: [WinCairo] Consolidate CMake code related to CURL
https://bugs.webkit.org/show_bug.cgi?id=170860

Attachment 307163: Patch with CMake changes

https://bugs.webkit.org/attachment.cgi?id=307163&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307163
  --> https://bugs.webkit.org/attachment.cgi?id=307163
Patch with CMake changes

View in context: https://bugs.webkit.org/attachment.cgi?id=307163&action=review

cool

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

This can be removed.

> Source/WebCore/platform/Curl.cmake:21
> +if (CURL_FOUND)

If it's required, what does this check accomplish?


More information about the webkit-reviews mailing list