[webkit-reviews] review granted: [Bug 170789] [WebCrypto] Add support for ECDSA : [Attachment 307168] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 170789: [WebCrypto] Add support for ECDSA
https://bugs.webkit.org/show_bug.cgi?id=170789

Attachment 307168: Patch

https://bugs.webkit.org/attachment.cgi?id=307168&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 307168
  --> https://bugs.webkit.org/attachment.cgi?id=307168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307168&action=review

Looks great! Inching closer to complete WebCrypto!

Please confirm the iso-sim build failure is unrelated to your patch before
landing.

> Source/WebCore/crypto/mac/CommonCryptoDERUtilities.h:48
> +size_t bytesNeededForEncodedLength(size_t);

I wonder if these should have been namespaced as "WebCore::crypto:: ..."

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_E
CDSA.worker-expected.txt:397
> +PASS Bad usages: generateKey({name: ECDSA, namedCurve: P-521}, true, [sign,
verify, sign, sign, verify, deriveBits]) 

Excellent!

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/ecdsa.work
er-expected.txt:13
> +FAIL importVectorKeys step: ECDSA P-521 with SHA-512 verification
assert_unreached: importVectorKeys failed for ECDSA P-521 with SHA-512.
Message: ''Data provided to an operation does not meet requirements'' Reached
unreachable code

I wish these passed. Do we have a radar to deal with this? Or a bug on W3C to
fix?