[webkit-reviews] review granted: [Bug 170839] Implement a way in WebItemProviderPasteboard to perform actions after file loading completes : [Attachment 307154] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 170839: Implement a way in WebItemProviderPasteboard to perform actions
after file loading completes
https://bugs.webkit.org/show_bug.cgi?id=170839

Attachment 307154: Patch

https://bugs.webkit.org/attachment.cgi?id=307154&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 307154
  --> https://bugs.webkit.org/attachment.cgi?id=307154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307154&action=review

You should note all the reviewers in your something somewhere and figure out if
it's enough.

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:297
> +    auto fileLoadingGroup =	adoptOSObject(dispatch_group_create());

extra space after =

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:302
> +	   dispatch_group_async(fileLoadingGroup.get(),
dispatch_get_main_queue(), ^ {

You're gonna use some lambadas.

> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:309
> +		       [[NSFileManager defaultManager]
removeItemAtURL:destinationURL.get() error:nil];

You're going to get rid of this.