[webkit-reviews] review granted: [Bug 170859] webkit-patch failed to detect git repository : [Attachment 307162] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 16:08:34 PDT 2017

Daniel Bates <dbates at webkit.org> has granted Bill Ming <mbbill at gmail.com>'s
request for review:
Bug 170859: webkit-patch failed to detect git repository

Attachment 307162: Patch


--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 307162
  --> https://bugs.webkit.org/attachment.cgi?id=307162

View in context: https://bugs.webkit.org/attachment.cgi?id=307162&action=review

The change looks good. The ChangeLog is out-of-date and I noticed some minor
stylistic issues with it. Please update it. You do not need to post this patch
for review again (though feel free to ask for one if you want one or make
changes other than fixing the ChangeLog entry). When you update the ChangeLog
entry change the  "Reviewed by NOBODY (OOPS!)" line to "Reviewed by Daniel
Bates." and upload the patch without a review flag and with the cq flag set to

> Tools/ChangeLog:3
> +	   webkit-patch failed to detect git repository.

Minor: Remove the period at the end of this line so that it matches the
Bugzilla title verbatim.

> Tools/ChangeLog:8
> +	   When -C is given to git, using double quotes for the path.

Please add an empty line below this line.

> Tools/ChangeLog:10
> +	   * Scripts/VCSUtils.pm:
> +	   (isGitDirectory):

This file/function listing is out-of-date. Please generate this ChangeLog entry
again using prepare-ChangeLog.

More information about the webkit-reviews mailing list