[webkit-reviews] review denied: [Bug 170859] webkit-patch failed to detect git repository : [Attachment 307146] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 15:45:08 PDT 2017


Daniel Bates <dbates at webkit.org> has denied Bill Ming <mbbill at gmail.com>'s
request for review:
Bug 170859: webkit-patch failed to detect git repository
https://bugs.webkit.org/show_bug.cgi?id=170859

Attachment 307146: Patch

https://bugs.webkit.org/attachment.cgi?id=307146&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 307146
  --> https://bugs.webkit.org/attachment.cgi?id=307146
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307146&action=review

Thank you for filing this bug and posting a patch. There are more places that
we need to modify. You may find it useful to look at the patch on bug #169003,,
which added the -C option to various code paths. Please grep through the code
as well to find any other occurrences that have been added since the patch for
bug #169003.

> Tools/ChangeLog:3
> +	   This change makes isGitDirectory() work on Windows.

This line should be the Bugzilla bug title verbatim. The description of the
change goes below the "Reviewed by" line.


More information about the webkit-reviews mailing list