[webkit-reviews] review granted: [Bug 170196] Web Inspector: new icon for Disable Caches button in Network Tab : [Attachment 307147] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 15:36:31 PDT 2017


Matt Baker <mattbaker at apple.com> has granted Jon Davis <jond at apple.com>'s
request for review:
Bug 170196: Web Inspector: new icon for Disable Caches button in Network Tab
https://bugs.webkit.org/show_bug.cgi?id=170196

Attachment 307147: Patch

https://bugs.webkit.org/attachment.cgi?id=307147&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 307147
  --> https://bugs.webkit.org/attachment.cgi?id=307147
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307147&action=review

r=me, address Joe's comment and also mention the new artwork in the change log
(only the update to the Clear button is mentioned).

In general for changes like this a before/after screen shot for changing
artwork is nice.

> Source/WebInspectorUI/ChangeLog:11
> +	   * UserInterface/Images/IgnoreCaches.svg: Added.

I think this should be singular: IgnoreCache.svg


More information about the webkit-reviews mailing list