[webkit-reviews] review granted: [Bug 170851] GraphicsLayerCA::recursiveCommitChanges should not descend into subtrees without changes : [Attachment 307125] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 170851: GraphicsLayerCA::recursiveCommitChanges should not descend into
subtrees without changes
https://bugs.webkit.org/show_bug.cgi?id=170851

Attachment 307125: patch

https://bugs.webkit.org/attachment.cgi?id=307125&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 307125
  --> https://bugs.webkit.org/attachment.cgi?id=307125
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307125&action=review

Nice, I always wanted to do this.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4033
> +	   if (ancestorCA.m_hasDescendantsWithUncommittedChanges)
> +	       return;
> +	   ancestorCA.m_hasDescendantsWithUncommittedChanges = true;

I would prefer you go through a setter and not poke the member variable
directly.