[webkit-reviews] review granted: [Bug 153892] [GTK] Web Inspector: Add new GTK+ icons for instrument icons : [Attachment 307111] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 14 11:14:07 PDT 2017

Joseph Pecoraro <joepeck at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 153892: [GTK] Web Inspector: Add new GTK+ icons for instrument icons

Attachment 307111: Patch


--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307111
  --> https://bugs.webkit.org/attachment.cgi?id=307111

View in context: https://bugs.webkit.org/attachment.cgi?id=307111&action=review

r=me, but consider simplifying the svg a bit!

> Source/WebInspectorUI/UserInterface/Images/gtk/NetworkInstrument.svg:12
> +<svg
> +   xmlns:dc="http://purl.org/dc/elements/1.1/"
> +   xmlns:cc="http://creativecommons.org/ns#"
> +   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
> +   xmlns:svg="http://www.w3.org/2000/svg"
> +   xmlns="http://www.w3.org/2000/svg"
> +   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
> +   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
> +   sodipodi:docname="NetworkInstrument.svg"

There is a pretty good chance that you can reduce the size of these SVGs
significantly by eliminating unnecessary references and simplifying a bit.

  • the metadata is not necessary for rendering (dc, cc, rdf)
  • inkscape / sodipodi attributes appear to be for editors only, they won't
affect rendering
  • docname is not necessary, this file already has a name
  • some style attributes have unnecessary properties (especially for fonts)
  • some values can be simplified as the large number of decimals are unlikely
to be necessary in some cases (.0002 and .9997)

I can understand if you want to leave some of the attributes to make future
editing easier, but we've found that is often not the case with our images.

More information about the webkit-reviews mailing list