[webkit-reviews] review granted: [Bug 170778] Refactor enumerateDevices to allow separate CaptureDeviceManagers for audio and video. : [Attachment 307040] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 170778: Refactor enumerateDevices to allow separate CaptureDeviceManagers
for audio and video.
https://bugs.webkit.org/show_bug.cgi?id=170778

Attachment 307040: Patch

https://bugs.webkit.org/attachment.cgi?id=307040&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 307040
  --> https://bugs.webkit.org/attachment.cgi?id=307040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307040&action=review

> Source/WebCore/ChangeLog:3
> +	   Refactor enumerateDevices to allow dseparate CaptureDeviceManagers
for audio and video.

Nit: dseparate -> separate

> Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:63
> +#if PLATFORM(MAC)
> +	  
RealtimeMediaSourceCenter::singleton().setAudioCaptureDeviceManager(CoreAudioCa
ptureDeviceManager::singleton());
> +#else
> +	  
RealtimeMediaSourceCenter::singleton().setAudioCaptureDeviceManager(AVCaptureDe
viceManager::singleton());
> +#endif

Please add a FIXME with a bug number about changing this for iOS.

> Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:97
> +#if PLATFORM(MAC)
> +    m_audioCaptureDeviceManager =
&CoreAudioCaptureDeviceManager::singleton();
> +#else
> +    m_audioCaptureDeviceManager = &AVCaptureDeviceManager::singleton();
> +#endif

Ditto.