[webkit-reviews] review granted: [Bug 170705] Web Inspector: No context menu available via ENABLE_INSPECTOR_SERVER : [Attachment 307072] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 170705: Web Inspector: No context menu available via
ENABLE_INSPECTOR_SERVER
https://bugs.webkit.org/show_bug.cgi?id=170705

Attachment 307072: Patch

https://bugs.webkit.org/attachment.cgi?id=307072&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307072
  --> https://bugs.webkit.org/attachment.cgi?id=307072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307072&action=review

Excellent! r=me

> Source/WebInspectorUI/UserInterface/Views/SoftContextMenu.css:3
> + * Copyright (C) 2017 Sony Interactive Entertainment Inc.

Can you add this line to $inspectorLicense in
Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl

That is the copyright included appended to minified builds. I normally roll it
every now and then but since I remembered now we should add this proactively!

> Source/WebInspectorUI/UserInterface/Views/SoftContextMenu.js:195
> +	   // Squelch native Inspect Element.

I don't think "Squelch" is clear terminology.