[webkit-reviews] review granted: [Bug 170817] Air::RegLiveness should be constraint-based : [Attachment 307008] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 13 19:01:05 PDT 2017
Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 170817: Air::RegLiveness should be constraint-based
https://bugs.webkit.org/show_bug.cgi?id=170817
Attachment 307008: the patch
https://bugs.webkit.org/attachment.cgi?id=307008&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307008
--> https://bugs.webkit.org/attachment.cgi?id=307008
the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=307008&action=review
r=me
> Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:226
> + // FIXME: We can get this information from the liveness
constraints. Except of
> + // course we want to separate the earlies of one instruction
from the lates of
> + // the next.
Please make a bug and link here.
> Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:241
> + // FIXME: This could reg the register sets from somewhere
else, like the
> + // liveness constraints. Except we want those constraints to
be laid out like
> + // how they would have been by RegLiveness, since we want to
separate the lates
> + // of one inst from the earlies of the next.
reg => get
Also, please make a bug and link it here.
More information about the webkit-reviews
mailing list