[webkit-reviews] review granted: [Bug 170828] Remove unused SharedBuffer constructor : [Attachment 307029] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 13 16:48:46 PDT 2017

Brady Eidson <beidson at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170828: Remove unused SharedBuffer constructor

Attachment 307029: Patch


--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 307029
  --> https://bugs.webkit.org/attachment.cgi?id=307029

View in context: https://bugs.webkit.org/attachment.cgi?id=307029&action=review

> Source/WebCore/platform/SharedBuffer.cpp:230
> +    // This copies data unnecessarily right now. We should just use the
Vector instead of always copying it.

I don't find any value-add from this comment.

More information about the webkit-reviews mailing list