[webkit-reviews] review granted: [Bug 170741] webkitpy: Ignore previously launched pid when system is under stress : [Attachment 306835] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 170741: webkitpy: Ignore previously launched pid when system is under
stress
https://bugs.webkit.org/show_bug.cgi?id=170741

Attachment 306835: Patch

https://bugs.webkit.org/attachment.cgi?id=306835&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 306835
  --> https://bugs.webkit.org/attachment.cgi?id=306835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306835&action=review

r=me

> Tools/Scripts/webkitpy/port/simulator_process.py:96
> +	       raise Exception('Faild to launch {}, kept receiving old
PID'.format(os.path.basename(self._cmd[0])))

Jonathan says this should be a RuntimeException.

Adding a blank space before the "try:" line would make this easier to read.