[webkit-reviews] review granted: [Bug 170573] WebAssembly: We should be able to postMessage a JSWebAssemblyModule : [Attachment 307005] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 13 11:48:30 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 170573: WebAssembly: We should be able to postMessage a JSWebAssemblyModule
https://bugs.webkit.org/show_bug.cgi?id=170573

Attachment 307005: patch

https://bugs.webkit.org/attachment.cgi?id=307005&action=review




--- Comment #12 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 307005
  --> https://bugs.webkit.org/attachment.cgi?id=307005
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307005&action=review

> Source/JavaScriptCore/ChangeLog:12
> +	   This patch adds a callback to JSRunLoopTimer to notify
> +	   clients that a timer has been set. This is used inside
> +	   WorkerRunLoop in WebCore so that its RunLoop can perform
> +	   an iteration when it sees that a timer got set.
> +

It would be super useful to call out in this change log that we are
postMessaging modules by just sharing them.


More information about the webkit-reviews mailing list