[webkit-reviews] review granted: [Bug 170815] Fix CMake build : [Attachment 307001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 13 11:35:43 PDT 2017


Beth Dakin <bdakin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 170815: Fix CMake build
https://bugs.webkit.org/show_bug.cgi?id=170815

Attachment 307001: Patch

https://bugs.webkit.org/attachment.cgi?id=307001&action=review




--- Comment #2 from Beth Dakin <bdakin at apple.com> ---
Comment on attachment 307001
  --> https://bugs.webkit.org/attachment.cgi?id=307001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307001&action=review

I'm guessing this is fixing multiple build fixes?

> Source/WebCore/PlatformMac.cmake:-266
> -    loader/cf/SubresourceLoaderCF.cpp

Is this also needed?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-761
> -    return NO;

Same, is this also needed?


More information about the webkit-reviews mailing list