[webkit-reviews] review granted: [Bug 168178] [INTL] Change Intl prototypes to plain objects : [Attachment 302762] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 168178: [INTL] Change Intl prototypes to plain objects
https://bugs.webkit.org/show_bug.cgi?id=168178

Attachment 302762: Patch

https://bugs.webkit.org/attachment.cgi?id=302762&action=review




--- Comment #9 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 302762
  --> https://bugs.webkit.org/attachment.cgi?id=302762
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302762&action=review

r=me

>> LayoutTests/js/script-tests/intl-numberformat.js:283
>> +shouldBe("Intl.NumberFormat('fr').format(1234.567)", "'1\\xA0234,567'");
> 
> I changed this to an escaped code because I couldn't manage to get my text
editor to insert the right space character.

One might say your editor broke the non-breaking spaces.