[webkit-reviews] review granted: [Bug 170798] Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost : [Attachment 306959] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 170798: Make WebCore::topPrivatelyControlledDomain() return "localhost" for
localhost
https://bugs.webkit.org/show_bug.cgi?id=170798

Attachment 306959: Patch

https://bugs.webkit.org/attachment.cgi?id=306959&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 306959
  --> https://bugs.webkit.org/attachment.cgi?id=306959
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306959&action=review

> Source/WebCore/platform/mac/PublicSuffixMac.mm:48
> +    if ([domain _web_looksLikeIPAddress] || [domain
isEqualToString:@"localhost"])

Let's do a case-insensitive comparison and add a test for LocalHost.