[webkit-reviews] review granted: [Bug 170750] BreakingContext::WordTrailingSpace cleanup. : [Attachment 306852] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted zalan <zalan at apple.com>'s
request for review:
Bug 170750: BreakingContext::WordTrailingSpace cleanup.
https://bugs.webkit.org/show_bug.cgi?id=170750

Attachment 306852: Patch

https://bugs.webkit.org/attachment.cgi?id=306852&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 306852
  --> https://bugs.webkit.org/attachment.cgi?id=306852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306852&action=review

> Source/WebCore/rendering/line/BreakingContext.h:67
> +    WordTrailingSpace(const RenderStyle& style, bool
measuringWithTrailingWhitespaceIsEnabled = true)

I'd get rid of the "Is" from the name.

> Source/WebCore/rendering/line/BreakingContext.h:834
> +    WordTrailingSpace wordTrailingSpace(style, !textLayout);

Wow, Lyin' width measurements really went wacko today. Made all sorts of crazy
repaint errors. Can't function under complex scripts - not very presidential.
Sad!