[webkit-reviews] review granted: [Bug 170636] [WebCrypto] Support HKDF : [Attachment 306563] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 170636: [WebCrypto] Support HKDF
https://bugs.webkit.org/show_bug.cgi?id=170636

Attachment 306563: Patch

https://bugs.webkit.org/attachment.cgi?id=306563&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 306563
  --> https://bugs.webkit.org/attachment.cgi?id=306563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306563&action=review

Looks good. Can you please confirm the failure are expected? Are they dependent
on other unfinished work?

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:5
> +FAIL Derived key of type name: AES-CBC length: 128  using short derivedKey,
normal salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Is this expected?

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:9
> +FAIL Derived key of type name: AES-CBC length: 192  using short derivedKey,
normal salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Ditto all the other instances of these...

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:623
> +FAIL Derived key of type name: AES-CBC length: 128  using short derivedKey,
empty salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Ditto...

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:1241
> +FAIL Derived key of type name: AES-CBC length: 128  using long derivedKey,
normal salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Ditto ...

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:1859
> +FAIL Derived key of type name: AES-CBC length: 128  using long derivedKey,
empty salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Ditto...

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:2477
> +FAIL Derived key of type name: AES-CBC length: 128  using empty derivedKey,
normal salt, SHA-384, with normal info with bad hash name SHA384 assert_equals:
deriveKey with bad hash name correctly threw NotSupportedError: Member
HkdfParams.info is required and must be an instance of BufferSource expected
"NotSupportedError" but got "TypeError"

Ditto...

>
LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.
worker-expected.txt:3092
> +FAIL empty derivedKey, empty salt, SHA-384, with normal info
assert_unreached: deriveBits failed with error OperationError: The operation
failed for an operation-specific reason Reached unreachable code

Ditto...