[webkit-reviews] review granted: [Bug 170796] Add some more WebRTC tests : [Attachment 306951] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 170796: Add some more WebRTC tests
https://bugs.webkit.org/show_bug.cgi?id=170796

Attachment 306951: Patch

https://bugs.webkit.org/attachment.cgi?id=306951&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 306951
  --> https://bugs.webkit.org/attachment.cgi?id=306951
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306951&action=review

> LayoutTests/webrtc/multi-video.html:25
> +video1 = document.getElementById("video1");
> +video2 = document.getElementById("video2");
> +video3 = document.getElementById("video3");
> +video4 = document.getElementById("video4");
> +video5 = document.getElementById("video5");
> +video6 = document.getElementById("video6");
> +canvas = document.getElementById("canvas");

Nit: technically none of these are necessary since the elements all have ids
with the same names.

> LayoutTests/webrtc/multi-video.html:50
> +    assert_true(data[index] < 100, "test 1 for " + id);
> +    assert_true(data[index + 1] < 100, "test 2 for " + id);
> +    assert_true(data[index + 2] < 100, "test 3 for " + id);
> +
> +    index = 80;
> +    assert_true(data[index] > 200, "test 4 for " + id);
> +    assert_true(data[index + 1] > 200, "test 5 for " + id);
> +    assert_true(data[index + 2] > 200, "test 6 for " + id);
> +
> +    index += 80;
> +    assert_true(data[index] > 200, "test 7 for " + id);
> +    assert_true(data[index + 1] > 200, "test 8 for " + id);
> +    assert_true(data[index + 2] < 100, "test 9 for " + id);

Nit: you could use a template literals for these, eg. `test 1 for ${id}`, etc